elementary / switchboard-plug-about

Switchboard System Plug
GNU General Public License v3.0
25 stars 17 forks source link

HardwareView: Make hostname editable #321

Closed ryonakano closed 3 months ago

ryonakano commented 3 months ago

Fixes #248 Fixes elementary/switchboard-plug-sharing#53

Pressing Enter key in the entry now sets the hostname.

Currently we show the hostname only when the hardware is not made by OEM. So, I separate the widget that shows either hostname or the product name into two different widgets.


With OEM info, successfully acquired the Polkit permission to edit hostname:

スクリーンショット 2024-06-02 00 11 48

Without OEM info, failed to acquire the permission:

スクリーンショット 2024-06-02 00 13 06

danirabbit commented 3 months ago

I wonder if we also need to add something about a restart being required? It looks like for example Bluetooth sharing name isn't change until we restart