search

elementary / switchboard-plug-applications

Switchboard Applications Plug
https://elementary.io
GNU General Public License v3.0
14 stars 12 forks source link

Provide fallbacks for KeyFile name and comment when absent or blank #144

Closed jeremypw closed 3 years ago

jeremypw commented 3 years ago

Fixes #141 although custom commands should ideally provide their own name and comment -unclear whether this can be enforced - requires a separate PR.

danirabbit commented 3 years ago

@jeremypw can you resolve conflicts with master?

jeremypw commented 3 years ago

Conflicts resolved

jeremypw commented 3 years ago

This is only a stop-gap really. There are a number of deficiencies in the handling of custom startup commands should anyone be moved to address them.

marbetschar commented 3 years ago

I'm no longer able to reproduce on Odin - so I guess this has been fixed and can be closed (along with the corresponding issue)?

Screenshot from 2021-09-01 08-23-04

jeremypw commented 3 years ago

@marbetschar OK, thanks for checking it out!