elementary / switchboard-plug-applications

Switchboard Applications Plug
https://elementary.io
GNU General Public License v3.0
14 stars 12 forks source link

Custom directory access gets overwritten when opening Applications plug #155

Closed zelikos closed 3 years ago

zelikos commented 3 years ago

What Happened

If you give a Flatpak app access to a specific directory (such as the flatpak override command, or with Flatseal), opening the Applications plug overwrites this as the Permissions view doesn't currently support granular filesystem permissions.

An example of this in practice is for the Steam Flatpak; granting access to a specific directory, such as a separate/external drive containing your games library, is necessary if you don't want to, or can't, install all of your games in your home directory. The Steam Flatpak also doesn't run if access to the home directory is granted, so that can't be used as a workaround. Local overrides also seem to take priority over system-wide overrides, so having a system-wide override doesn't work as a workaround either, as the Applications plug leaves an empty override file if the app has default permissions.

Expected Behavior

Resolving #145 would be ideal in the long term. In the short term, not overwriting access to specific directories (although I'm not sure if the short-term solution is feasible or not).

Steps to Reproduce

Using Steam as an example for simplicity, but any Flatpak app can be substituted:

  1. flatpak override --user --filesystem=/path/to/directory com.valvesoftware.Steam
  2. cat ~/.local/share/flatpak/overrides/com.valvesoftware.Steam to confirm directory access was granted
  3. Open System Settings -> Applications
  4. Repeat step 2, see custom directory is no longer there

Logs

Platform Information

elementary OS 6 Early Access

queeup commented 3 years ago

Confirm. Always resets my overrides.

jalcine commented 3 years ago

Okay, I thought I was freaking out here, thanks for confirming this! I wonder if it'd help to have another tab for apps to have 'mounted directories' or 'allowed paths' versus doing the "Home" / "System" all-or-nothing approaches.

jhaygood86 commented 3 years ago

This will be fixed by #168 -- underlying cause is that the plug didn't play nice with overrides set via other means

jalcine commented 3 years ago

Exciting!

On Wed, Sep 15, 2021, at 23:24, Justin Haygood wrote:

This will be fixed by #168 -- underlying cause is that the plug didn't play nice with overrides set via other means

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/elementary/switchboard-plug-applications/issues/155#issuecomment-920545697