search

elementary / switchboard-plug-datetime

Switchboard Date & Time Plug
GNU General Public License v3.0
10 stars 8 forks source link

Does the new layout look better if its components are centered? #69

Closed 4jNsY6fCVqZv closed 9 months ago

4jNsY6fCVqZv commented 5 years ago

Thanks for the new layout of switchboard-plug-datetime!

That's how the design looks to me right now. Screenshot cleaned

Do you think it would be better to center the components more? An evaluation is difficult for me personally, because I have looked at the other plugins, and these look visually different.

worldofpeace commented 5 years ago

I believe this is what you're looking for #61

4jNsY6fCVqZv commented 5 years ago

Hi, I'm afraid not. In your example it is even "worse", because the display "24h" even overlaps the "Search Settings" bar at the top. From my perception, the arrangement is right-justified rather than centered. And that's what I want to express with the issue here. Do you understand? My idea would be to arrange it in a direct line under "Time & Date".

worldofpeace commented 5 years ago

I didn't write the code, but I'm sure for https://github.com/elementary/switchboard-plug-datetime/pull/61 your suggestions would be welcome on how we can make it look better :+1:

ryonakano commented 5 years ago

Screenshot from 2019-08-20 07-59-32

Screenshot from 2019-08-20 08-03-23

Hmm, I guess the layouts of both master and #61 is centered horizontally.

worldofpeace commented 5 years ago

Right, I'm assuming because of the now-defunct map it appeared centered as well. (though not actually)

4jNsY6fCVqZv commented 5 years ago

I have switchboard-plug-datetime 2.1.6 running, unfortunately it looks like in my screenshot. So the master branch's fixing that?

ryonakano commented 5 years ago

@4jNsY6fCVqZv As far as comparing the master and 2.1.6, there are no code changes, so the layout is not changed at all.

4jNsY6fCVqZv commented 5 years ago

@ryonakano Could it be that your screenshot was taken in maximized mode and mine in non-maximized mode? And does this distort the way the plugin is displayed?

ryonakano commented 5 years ago

@4jNsY6fCVqZv Nope, both of ours ware taken in non-maximized mode. FYI the following one is taken in maximized mode, whose contents seems to be still centered.

Screenshot from 2019-08-20 21-42-11

4jNsY6fCVqZv commented 5 years ago

Okay, the problem from my point of view is that I can't reset a window size to default once I've resized it. And that leads to a situation where there is no centering for unmaximized windows, right?

danirabbit commented 9 months ago

Closing since the layout is now more centered/vertical and in a clamp :)