search

elementary / switchboard-plug-display

Switchboard Displays Plug
https://elementary.io
GNU General Public License v3.0
14 stars 18 forks source link

not only allow whole hours in the user-defined settings #155

Closed 4jNsY6fCVqZv closed 5 years ago

4jNsY6fCVqZv commented 5 years ago

what it says on the thin. At the moment it is possible to enter half and quarter hours (or values like 18:03) in a 24 hour time system, but as soon as I close Switchboard, the setting is reset to the last output value.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/70299178-not-only-allow-whole-hours-in-the-user-defined-settings?utm_campaign=plugin&utm_content=tracker%2F60457221&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F60457221&utm_medium=issues&utm_source=github).
peteruithoven commented 5 years ago

Looking at the code it's saved at /org/gnome/settings-daemon/plugins/color/night-light-schedule-from. Looking at that using dconf editor it seems like the minutes value is actually stored. So there must be something going wrong when reading these settings when the view is started.

4jNsY6fCVqZv commented 5 years ago

Thanks Cody for moving! Peter, do you think that the setting also works correct with 18:03, for example, but is just not shown in the plugin?

4jNsY6fCVqZv commented 5 years ago

@peteruithoven The issue is still relevant. Any idea how to solve this elegantly?

ryonakano commented 5 years ago

@4jNsY6fCVqZv I've submitted a PR (#173) that should fix this issue.

4jNsY6fCVqZv commented 5 years ago

@ryonakano Thank you very much, hope it works as intended and can be merged!