(2/5) Multiple Issues: Snap monitors after mouse button release

elementary / switchboard-plug-display

Switchboard Displays Plug

https://elementary.io

GNU General Public License v3.0

14 stars 18 forks source link

(2/5) Multiple Issues: Snap monitors after mouse button release #181

Closed felix-andreas closed 5 years ago

felix-andreas commented 5 years ago

(2/5) Split up #177 in different PRs:

Needs to be merged after #180

Changes in this PR:

a more concise widget snapping algorithm
fixes some issues when the widgets were perfectly aligned (#154)

Shows that it is now possible to perfectly align montiors. The magnetic edges will be introduced in (5/5). align-monitors

jeremypw commented 5 years ago

I am reviewing https://github.com/elementary/switchboard-plug-display/pull/182 which incorporates this PR. I do not think this PR does needs to be merged separately.

felix-andreas commented 5 years ago

@jeremypw, I just wanted to point out, that in #177 danielrabbit asked to split the PR into smaller different PRs:

Thanks for your contribution! To make the review process more speedy and easier on reviewers and to have a cleaner commit history, I would really appreciate it if you would break this up into several smaller pull requests that only make one of these changes per PR

Wouldn't it then not also make sense to merge them separately?

jeremypw commented 5 years ago

OK, I see you have backported the relevant changes from the 3/5 review so I guess I can merge them separately.