List virtual monitors with controls in a sidebar

[jeremypw]

Fixes #74 Fixes #131 Fixes #274

Moves monitor controls into a sidebar, more in line with other plugs. Display view mainly used for positioning.

• [x] Add sidebar
• [x] Add monitor widgets with use switch
• [x] Connect use switch and apply effects
• [x] Refresh sidebar and view when configuration changes

Some effort went into making sure the plug is stable when reversing proposed changes and cancelling changes after application. Some of these issues may have been present in master and may now be fixed:

294

292?

289

287(part2)

273

269?

226

128

So far it has only been tested with one external and one builtin monitor.

[cassidyjames]

@jeremypw I haven't built this locally yet, but I suppose this fixes #74 as well? :wink:

[cassidyjames]

@jeremypw Okay I pulled this to look at it. I think this might actually be too disruptive design-wise; in #74 I kept the "Configure display" gear menu at the top-right of each display, and only used the sidebar to enable/disable displays. I think I like that more as generally configuring displays should not be necessary; the defaults are good, but enabling/disabling and rearranging is the primary use.

Screenshot of this branch for anyone lurking:

I also added more context to the design of #74 on that issue if that helps @jeremypw.

[jeremypw]

[jeremypw]

I did put screenshots in originally - but forgot to press Enter! I wasn't aware of #74 tbh. In an early version of this I put the display configuration controls under a MenuButton in each Sidebar widget, but since there is plenty of space in the sidebar, there didn't seem a lot of point in hiding them. Personally I think it is more logical to have all the controls together in the sidebar and just use the display view to show and adjust the layout of the the displays. The plug (like most plugs) is not going to be used regularly anyway.

[jeremypw]

I would not be averse to putting the controls into a revealer so that they are not always visible though.

[cassidyjames]

@jeremypw It doesn't really make sense with the typical design of a sidebar, though, and would require a whole new design to try and decide how it would work. I would really like to keep the controls as they are in master in a popover on the layout widgets as I originally designed.

[jeremypw]

OK, will revert the controls (except the active switch) to the display widget.

[jeremypw]

Now looks like this.

[jeremypw]

COnverting to draft as does not fully implement the linked design issue.

[mustafa-git]

131 and #274 have been broken since Juno if not earlier and preventing me (and possibly others) from using Elementary. Rather than going unfixed for another release, could the developers perhaps merge the fixes and discuss design separately? Sorry if it's any inconvenience.

[jeremypw]

Tbh, I had forgotten about this PR. Not sure what needs to be done with it now. I guess I can try and pull out the fixes and apply to the existing UI.

[jeremypw]

Closing due to Gtk4 port