search

elementary / switchboard-plug-display

Switchboard Displays Plug
https://elementary.io
GNU General Public License v3.0
14 stars 18 forks source link

Fix use this display switch #311

Closed davidmhewitt closed 3 years ago

davidmhewitt commented 3 years ago

Fixes #131

There have been a few attempts at solving this issue, most of which seem to revolve around redesigning large parts of the plug and then they never get much traction as a result.

This fixes the linked issue in the most minimally invasive way possible.

cassidyjames commented 3 years ago

@davidmhewitt thank you for this! I think the only remaining thing is to change the primary display as well, as if the disabled display is set as primary, the switch appears to do nothing (but changing the primary and then disabling the display works). Alternatively, we can disable the switch on the primary display.

Hedronmx commented 3 years ago

Not sure if I should post this or open a new issue but I compiled the master and the switch still does nothing, even when changing primary display.

I get ** (io.elementary.switchboard:7219): CRITICAL **: 15:30:33.253: MonitorManager.vala:241: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Logical monitors positions are offset

Screenshot from 2021-08-18 15-31-01

davidmhewitt commented 3 years ago

You should open a new issue. It would be hard to keep track of issues reported in merged pull requests.

In your new issue, could you explain the physical layout of your monitors and where in the logical layout the monitor you tried to disable was? It looks like it's on top in your screenshot, but I'm not sure if that's a side effect of trying to disable it.

Hedronmx commented 3 years ago

@davidmhewitt Just made a new issue, thanks for your time.