search

elementary / switchboard-plug-display

Switchboard Displays Plug
https://elementary.io
GNU General Public License v3.0
14 stars 18 forks source link

Prefer the resolution modes marked is_preferred #337

Closed vjr closed 1 year ago

vjr commented 1 year ago

Fixes #338

This patch checks whether the is_preferred flag has been set on any of the modes and if so then only add those modes to the recommended resolution list and the rest to the other list.

If none of the modes have the is_preferred flag set to true then the current behaviour is maintained.

Current behaviour (before this patch) is that the max supported resolutions aspect ratio (not necessarily native) are placed into the recommended list with undesirable (?) results, at least on my 4K UHD (3840x2160) TV with native aspect ratio of 16:9

See the before and after screenshots:

BEFORE:

display_before_cropped

AFTER:

display_after_cropped

vjr commented 1 year ago

Second commit pushed to restore the recommended list because the first commit was hiding all the other non-preferred native resolutions on my main monitor.

Now the TV resolution list (acceptable?) looks like this:

display_after2_cropped

vjr commented 1 year ago

Fixes #338

Going ahead and marking it ready for review because I was able to repro the issue and resolve with this PR.

If anyone from @elementary/desktop-developers can also test, at least that existing functionality works for you?

zeebok commented 1 year ago

Code itself looks alright. I can test this either later tonight or tomorrow for you!

vjr commented 1 year ago

The person who reported the issue has commented there that this PR resolves it for them too.

Note that there's still some improvements that can be done for re populating the resolution combobox when clicking APPLY or navigate away from the plug and returning back for which I have a diff in progress that I can propose after this PR gets merged.