search

elementary / switchboard-plug-display

Switchboard Displays Plug
https://elementary.io
GNU General Public License v3.0
14 stars 18 forks source link

Searching for "Display" shows System Settings deeplinks to options that don't exist #359

Open itsravenous opened 11 months ago

itsravenous commented 11 months ago

What Happened?

The following options are shown when searching for Displays in the app menu, but are not present in the Displays system settings module itself. Perhaps this is because my display (laptop) doesn't support them?

Displays -> Filters -> Monochrome Displays -> Rotation Lock

Steps to Reproduce

  1. Open app menu
  2. Search for "Displays"
  3. See Displays -> Filters -> Monochrome and Displays -> Rotation Lock options
  4. Click one of the options
  5. See it is not present in any of the Displays settings dialog tabs

Screen recording:

https://github.com/elementary/applications-menu/assets/1737376/78ddaa28-6245-4740-bffc-c3c3ce0f1a62

Expected Behavior

If these are valid options, just not for my current display, perhaps they should be hidden? Or perhaps they should be shown in the settings dialog but greyed out?

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

danirabbit commented 11 months ago

The "Monochrome" result exists so that you don't have to know if the setting is called "Monochrome" or "Grayscale" to find it, but that's understandably not as good as maybe having a keyword system.

I think we can hide the rotation lock search result, but that has to be done from System Settings side, so transferring there

itsravenous commented 11 months ago

I can have a go at a keyword/alias PR if that's helpful, or happy to leave it if you want to put some thought into it.