search

elementary / switchboard-plug-display

Switchboard Displays Plug
https://elementary.io
GNU General Public License v3.0
14 stars 18 forks source link

Port to GTK4 #369

Closed danirabbit closed 7 months ago

danirabbit commented 9 months ago

379 will solve some new warnings that come in GTK 4 but it's not strictly necessary to merge it first

danirabbit commented 7 months ago

@jeremypw fixed the button placement issue, but I also noticed since in GTK 4 the button is actually a child widget of MenuButton and MenuButton isn't a button subclass that it breaks some of the CSS here. This should be fixed with #379 so I'll leave that up to you if you think that should be merged first.

It looks like the popover's autohide gets broken when the displaywidget changes, so I have it popdown now when one of these breaking changes would occur. Is that an okay solution? I'm not sure how to solve it otherwise

jeremypw commented 7 months ago

@danirabbit Could you resolve the conflicts please?

danirabbit commented 7 months ago

@jeremypw done!