search

elementary / switchboard-plug-keyboard

Switchboard Keyboard Plug
GNU General Public License v2.0
28 stars 22 forks source link

Adding Multitasking View to Super Key Options #400

Closed MobileAZN closed 2 years ago

MobileAZN commented 2 years ago

Adding the ability for the Super key to also show the Multitasking View.

jeremypw commented 2 years ago

I do not like that a long and complicated string is written out explicitly twice, although a similar style is used in existing code.

MobileAZN commented 2 years ago

I have updated this to the suggested constant use and cleaner call.

MobileAZN commented 2 years ago

ah, ok. Updated using the sane defaults you offered @davidmhewitt

davidmhewitt commented 2 years ago

This is looking good now, but I'm going to mark it as blocked until we get https://github.com/elementary/gala/pull/1393 merged. I don't think this option should be available until it's also possible for the multitasking view to be closed with another press of the super key. So we'll await the status of that PR.

MobileAZN commented 2 years ago

haha! That was my next question, is where do I look to be able to close it with the same key vs hitting esc, as that was the next thing I wanted to look at. Thanks again for the help!