search

elementary / switchboard-plug-keyboard

Switchboard Keyboard Plug
GNU General Public License v2.0
28 stars 22 forks source link

Prepare for GTK4: Undepend from libgnomekbd #413

Closed treppenwitz03 closed 2 years ago

treppenwitz03 commented 2 years ago

Needed as preparation for https://github.com/elementary/switchboard-plug-keyboard/pull/412

treppenwitz03 commented 2 years ago

It spawns gkbd-keyboard-display but it does not output the correct layout.

jeremypw commented 2 years ago

@ZenitsuDev I think you can remove the libgnomekbd.* files from the /vapi directory?

jeremypw commented 2 years ago

@ZenitsuDev I have fixed the problem with displaying the correct layout for you.

jeremypw commented 2 years ago

Showing map with AppInfo (in the same way as the Wingpanel) since the previous way caused "not responding" warnings if the dialog was clicked on when the map was open. Now the map and the dialog are independent.

jeremypw commented 2 years ago

@danrabbit At the moment it is possible to show multiple maps (which stay open even after closing the dialog). I do not think this is a problem but if it is desired to show only one map and prevent the dialog from closing while it is open then additional code will be required.

danirabbit commented 2 years ago

Yeah it's slightly less than ideal, but I don't think it's worth spending a lot of time trying to alter it. Seems fine as is to me :+1: