elementary / switchboard-plug-keyboard

Switchboard Keyboard Plug
GNU General Public License v2.0
28 stars 22 forks source link

Custom Shortcuts: New add/remove list pattern #414

Closed lenemter closed 2 years ago

lenemter commented 2 years ago

image

jeremypw commented 2 years ago

@lenemter Could you add some reasons for these changes to assist review? Thanks.

lenemter commented 2 years ago

@jeremypw IMO the current way of deleting custom shortcuts is inconvenient. I think that most users expect a "Remove" button in gear menu, but instead they have to select the shortcut and press the "-" button at the very bottom of the list

lenemter commented 2 years ago

I think i forgot to make "Add Shortcut" translatable