elementary / switchboard-plug-keyboard

Switchboard Keyboard Plug
GNU General Public License v2.0
28 stars 22 forks source link

Port to GTK 4 #480

Closed danirabbit closed 10 months ago

danirabbit commented 1 year ago

Closes #412

jeremypw commented 10 months ago

Adding and removing layouts and input engines seems to work OK except that adding an input engine (Japanese Anthy) and immediately removing it invalidates the installed keyboard layout (English (UK)) - however master has the same issue. Shortcuts seems to work OK except cannot use Fn as modifier for custom shortcuts. I cannot check whether master has the same problem as Custom Shortcuts has stopped working there.

The cursor blinking scale seems to operate the unexpected way? Increase the value slows the speed of blinking even thought the header is "Speed" - but this is the same as master. The duration scale did not have a noticeable effect - same as master. Maybe reconsider the wording of the labels e.g. "Interval on" and "Interval off"?

Sound setings hyperlink not working - presumably because not ported yet.

danirabbit commented 10 months ago

@jeremypw thanks for the review! For any issues that also exist in master could you open issue reports please? This is just a port and doesn't really seek to solve existing issues.

Sound settings link is working here. Do you have the io.elementary.settings.sound installed?

Fixed the linkbutton issue!

jeremypw commented 10 months ago

o you have the io.elementary.settings.sound installed?

Ah, no. That would explain it!