elementary / switchboard-plug-locale

Switchboard Locale Plug
GNU Lesser General Public License v3.0
11 stars 10 forks source link

Throw an error dialog when an installation of language failed #112

Closed ryonakano closed 4 months ago

ryonakano commented 5 years ago

Prerequisites

Describe the bug

If an installation of language failed, no error dialog is shown thus there's no way for users to know if the installation succeeded or failed.

To Reproduce

~1. Turn off your Internet connection so that fetching the language pack gets impossible and the installation fails

  1. Open the Locale Plug and try to install some language
  2. The installation dialog is shown but soon disappeared
  3. The language list in the left pane is updated but the language you chose is not there because its installation failed. Nevertheless, no error dialog is shown~

Edit: the above method seems to be invalid… :thinking: I don't know how to trigger an error but as far as seeing the source code all try {…} catch {…} sentences only have a warning and don't seem to show anything to the UI.

Expected behavior

An error dialog is shown if an installation of language failed.

Platform Information

Screenshot from 2019-09-29 18-59-52

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/81094599-throw-an-error-dialog-when-an-installation-of-language-failed?utm_campaign=plugin&utm_content=tracker%2F60175852&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F60175852&utm_medium=issues&utm_source=github).