search

elementary / switchboard-plug-locale

Switchboard Locale Plug
GNU Lesser General Public License v3.0
11 stars 10 forks source link

InstallPopover: Rewrite as ListBox #96

Closed danirabbit closed 5 years ago

danirabbit commented 5 years ago

Fixes #3

Screenshot from 2019-09-13 09 39 52@2x

ryonakano commented 5 years ago

Screenshot from 2019-09-13 08-34-08

The row is shown as selected when we select a language in the popover with the current master branch.

Screenshot from 2019-09-13 08-35-44

However, it is not with this branch, which I personally feel I'm not sure which language I selected. I'm OK if this change is intentional though.

danirabbit commented 5 years ago

I'm not sure how to work around this. Actually what's supposed to happen is the popover will close, but instead it waits until after we authenticate to do anything else, including draw the selection.

danirabbit commented 5 years ago

@ryonakano I've changed the design to match the Keyboard Layout popover with a more explicit two steps. Select and then button to activate. This should make it more clear which language will be installed

kgrubb commented 5 years ago

Following the steps in the related issue, it looks like pressing enter will attempt to authenticate before password prompting. Typing the password in after the first failed attempt works, though. When the install dialog opens, the search goes away as expected.

ezgif com-optimize

ryonakano commented 5 years ago

@danrabbit Looks nice! Although the popover is still not closed until authentication, I guess that's OK. However, as @kgrubb mentions pressing enter in the search entry will attempt to authenticate before password prompting. I can sometimes confirm this issue with the latest master branch too but it seems we face this issue with this branch whenever pressing enter in the search entry, which I guess we might want to fix.

danirabbit commented 5 years ago

I'm thinking this is an issue in the polkit dialog because it happens with other apps too, but I'm really not sure why this keypress gets passed into the dialog

kgrubb commented 5 years ago

In that case, I'd think that the polkit trigger is out of the scope of this pr.

To me, it looks like the changes in this pr work as intended, and we can handle the weird polkit issue in another issue/pr?