elementary / switchboard-plug-mouse-touchpad

Switchboard Mouse & Touchpad Plug
GNU General Public License v3.0
24 stars 13 forks source link

Settings for multi-touch gestures #157

Closed JoseExposito closed 3 years ago

JoseExposito commented 3 years ago

Let's work here to fix https://github.com/elementary/switchboard-plug-mouse-touchpad/issues/16 :D

Requires this version of Gala https://github.com/elementary/gala/pull/976

JoseExposito commented 3 years ago

This is ready!

It works better with the latest master of Touchégg because I improved the config file watcher for this use case. So I recommend to compile and install the latest version for testing. Available as deb package https://github.com/JoseExposito/touchegg/releases/tag/2.0.4

It also requires this version of Gala so the gesture settings are applied.

Testing is a little bit tricky because of the edge cases, but I believe I covered every single case. Including removing Touchégg or handling wrong XML settings.

JoseExposito commented 3 years ago

@danrabbit could you explain the issue a little bit please? I don't think I'm understanding the problem.

Make sure to delete your existing ~/.config/touchegg and use the correct default settings for testing: https://github.com/elementary/default-settings/blob/master/touchegg/touchegg.conf

This is how it should work:

Or at least that's how it works on my side, let me know if you are experimenting something else.

JoseExposito commented 3 years ago

By the way, I'm not happy with the tile window behaviour.

Once the window is tiled, it doesn't restore it's previous size when you move it. Even if I set the _NET_WM_STATE_MAXIMIZED_VERT atom, mutter is not handling it properly.

Honestly, I'll remove the action and either implement it in Gala (if possible), or replace it with: https://github.com/elementary/gala/issues/979 Obviously not using a shortcut, implementing it properly.

JoseExposito commented 3 years ago

Thoughts on the tile window issue @cassidyjames @danrabbit ? I will rather remove it than shipping it as it is. It is not production ready yet.

I get asked about the "Alt+Tab" gesture a lot. I guess that it's because Windows 10 use it by default and because it is not straight forward to configure it. I cannot know if tile is used more frequently though.

cassidyjames commented 3 years ago

@JoseExposito yeah I would remove the tiling for now. It would be easy enough to add back here for configuration once it works better.

Alt+Tab is interesting. I believe @davidmhewitt is working on a new design to address longstanding issues, so I think it would make sense to hold off on gestures but make sure he's aware and we can think about how that would work with this new design.