Closed worldofpeace closed 3 years ago
I'd like to disagree. On my laptop, without build in ethernet port), this Wired option only shows up when I plug in a usb to ethernet adapter. Seeing the status of that Wired hardware is interesting, it can tells me for example whether there is something wrong with the cable for example.
I do think that the contents of the Wired page could be improved in this case.
Sorry but I don't know what I mentioned that you've disagreed to.
On my laptop, without build in ethernet port), this Wired option only shows up when I plug in a usb to ethernet adapter. Seeing the status of that Wired hardware is interesting, it can tells me for example whether there is something wrong with the cable for example.
That makes it sound like I've suggested hiding this
And what I'm suggesting is that the view should also just display that hardware status similar to the wifi view and make the switch insensitive
Apologies, I misunderstood. Looks like we're actually on the same page.
Nice :smile:
Aside from displaying the hardware status, I think the toggle switch should also be disabled when there is no device to connect to or when there is no ethernet hardware present.
Aside from displaying the hardware status, I think the toggle switch should also be disabled when there is no device to connect to or when there is no ethernet hardware present.
why?
Forgot to include picture in my last comment. Here it is:
Connected using wifi and no ethernet cable connected. A bit confusing to me that I still can toggle ethernet on and it shows "unknown" as IP, as if I somehow screwed my configuration.
Yeah this is what I meant by "make the switch insensitive"
I still have this issue. There is an inconsistency between the switchboard plug and the wingpanel indicator.
I mean in the wingpanel indicator the "Wired" option is disabled, and cannot be activated as long as no ethernet cable is connected.
But in the switchboard plug the "Wired" option is always enabled, even if no ethernet cable is connected. Which is useless because it's displaying an "unknown" status.
In addition to that when you disable the "Wired" option in the switchboard plug and close the settings, it re-enables itself. So it can't be disabled.
I think the "Wired" view should adopt the same behavior than the wingpanel indicator mentionned above.
See the screenshots:
In the wingpanel indicator:
In the switchboard plug:
I suggested a fix, but it went unnoticed. Who needs to fix this (although it does not affect the functionality), here is the patch.
Because this is unplugged there's never going to be information to populate this with and the switch isn't going to effect the physical state. This should probably just show some text asking to connect an ethernet cable.