Danrabbit/vpn redesign

[danirabbit]

• Use Granite.MessageDialog
• Make connection a construction property since it's only ever set once
• Make VPNInfoLabel a private class since it's only ever used in one class
• Make sure state_label always has a status
• signals at the end

[arshubham]

Is there a reason your removed Granite.STYLE_CLASS_H4_LABEL Makes it much more readable in my opinion.

Also why is Revealer removed?

[danirabbit]

Yes because the H classes are for headings and none of these are headings. We don't use heading style class for this kind of label anywhere else in the OS

[arshubham]

Please also remove src/Widgets/VPN/VPNInfoLabel.vala from POTFILES

[danirabbit]

@arshubham done!

[danirabbit]

@arshubham I removed the revealer because I don't feel like it's a good idea to hide this functionality behind a mouseover effect. Hiding this button would not be consistent with Bluetooth settings or Wireless network settings