search

elementary / switchboard-plug-network

Switchboard Network Plug
GNU General Public License v3.0
19 stars 24 forks source link

The build fails against valac 0.46.3 #217

Closed ryonakano closed 4 years ago

ryonakano commented 4 years ago

After 0a64bd7 the build seems to fail against valac 0.46.3 with the following error messages:

../src/Views/WifiPage.vala:492.69-492.86: error: Argument 1: Cannot convert from `unowned GLib.GenericArray<weak NM.Connection>' to `unowned GLib.GenericArray<NM.Connection>'
                    var ap_connections = row.ap.filter_connections (device_connections);
                                                                    ^^^^^^^^^^^^^^^^^^
../src/Views/WifiPage.vala:494.74-494.87: error: The name `ap_connections' does not exist in the context of `Network.WifiInterface.wifi_activate_cb'
                    var valid_connection = get_valid_connection (row.ap, ap_connections);
                                                                         ^^^^^^^^^^^^^^
../src/Views/WifiPage.vala:495.25-495.40: error: The name `valid_connection' does not exist in the context of `Network.WifiInterface.wifi_activate_cb'
                    if (valid_connection != null) {
                        ^^^^^^^^^^^^^^^^
../src/Views/WifiPage.vala:496.65-496.80: error: The name `valid_connection' does not exist in the context of `Network.WifiInterface.wifi_activate_cb'
                        client.activate_connection_async.begin (valid_connection, wifi_device, row.ap.get_path (), null, null);
                                                                ^^^^^^^^^^^^^^^^
worldofpeace commented 4 years ago

This bulids for me on nixos with vala 0.46.5

tintou commented 4 years ago

You need NetworkManager past this commit https://github.com/freedesktop/NetworkManager/commit/201c153e25990f61421be9984ecca5bc71be5845