elementary / switchboard-plug-network

Switchboard Network Plug
GNU General Public License v3.0
20 stars 23 forks source link

Better Wifi encryption type handling #264

Closed davidmhewitt closed 4 years ago

davidmhewitt commented 4 years ago

We were hardcoding a wpa-psk key management type, which I suspect means Switchboard wasn't able to connect to anything other than WPA[2] networks. This doesn't seem to be necessary as the auth dialog still prompts for the correct type of Wifi credentials without this.

I've added some code that in theory supports WPA-Enterprise APs that use certificates and/or usernames and passwords for auth. This is based off code in GNOME's nm-applet.

I've also updated that code that decides what string to display under each network to check rsn_flags as well as wpa_flags for the encryption type as it was just showing every network as "Encrypted" for me. Now I get the proper "WEP/WPA" disambiguation.

This will need testing to check Switchboard can still add/connect a variety of Wifi networks. I can only realistically test WPA networks, as my router doesn't let me configure WEP, unsurprisingly :rofl:

Also worth noting that I've only tested this on focal, no testing has been performed on bionic.