search

elementary / switchboard-plug-network

Switchboard Network Plug
GNU General Public License v3.0
20 stars 23 forks source link

Display message unplugged cable #287

Closed andirsun closed 3 years ago

andirsun commented 3 years ago

fix : #149

Before :

Screenshot from 2020-11-30 00 52 43

After :

Screenshot from 2020-12-02 20 21 11

andirsun commented 3 years ago

Hey @danrabbit Thanks for the performance and code style tips!, as a web developer I'm a mess with vala but I love it! I hope to continue helping with more PR

Dirli commented 3 years ago

I'm certainly pleased that my code got into the tree (#187), but it's strange that this requires intermediaries.

danirabbit commented 3 years ago

@Dirli it looks like you closed your own pull request, so it's no wonder it was not reviewed 🙃

Dirli commented 3 years ago

Yes, you are right, I close them after a long time without response (because I don't understand the subject of this silence), well at least that's how they get there)