search

elementary / switchboard-plug-network

Switchboard Network Plug
GNU General Public License v3.0
20 stars 23 forks source link

Dark child window with light theme enabled (EOS 6 Beta) #295

Closed KarkanAlzwayed closed 3 years ago

KarkanAlzwayed commented 3 years ago

What Happened

When opening settings/network then clicking the "setting" button in front of my connected wifi name, the child "editing [Network name]" that pops up is dark themed even thought the whole system theme is set to "default" which is obviously light. Don't know if this is intentional or a bug.

Expected Behavior

All windows should follow the same chosen global theme.

Steps to Reproduce

Open settings/network then in front of your network name, click the "settings" button to get the child window that is used to edit your network.

Platform Information

EOS 6 Beta Screenshot from 2021-05-15 15-15-00

danirabbit commented 3 years ago

Hrm, this dialog comes from network manager, so it shouldn't be dark styled at all. OP have you modified your system in any way other than through System Settings? Such as with a tweaks app?

KarkanAlzwayed commented 3 years ago

@danrabbit I have tweaks installed but I'm using it for minimize button only in this instance. I do use it sometimes to change the folders to different colors. I'll double check and make sure I am using the default icons and try to recreat it. Or is it the mere existence of the elementary tweaks is the problem period?

danirabbit commented 3 years ago

@KarkanAlzwayed I have not read the source code, but I believe it does something with trying to force a dark style. I can't reproduce this issue and the only thing I can think that would cause it is some hack like tweaks

Closing as "Incomplete" until it can be reproduced on a system without tweaks

KarkanAlzwayed commented 3 years ago

@danrabbit would just removing tweaks suffice, or should I reinstall? I don't mind reinstalling at all as I've volunteered to test anyway.

danirabbit commented 3 years ago

@KarkanAlzwayed I don't know the answer to that since I don't know what tweaks is doing. You should bring it up with the tweaks maintainer

KarkanAlzwayed commented 3 years ago

@danrabbit no worries. I'll try both and report back. Thank you.

KarkanAlzwayed commented 3 years ago

@danrabbit ok, so I reinstalled the beta from scratch. No tweaks or any other third part stuff. This is just out of the box. While on default mode (light) the child window is themed correctly, but on dark, it is still light. Not sure if it is supposed to follow the global theme or not. See screenshot Screenshot from 2021-05-19 23-07-12@2x

danirabbit commented 3 years ago

@KarkanAlzwayed this dialog comes from GNOME Network Manager, so no it will not follow the dark style.

KarkanAlzwayed commented 3 years ago

@danrabbit Thank you, sir.