search

elementary / switchboard-plug-network

Switchboard Network Plug
GNU General Public License v3.0
20 stars 25 forks source link

Add support for libnm 1.43 #357

Closed meisenzahl closed 1 year ago

meisenzahl commented 1 year ago

Below are the versions of libnm that Fedora uses:

This project could not be compiled on Fedora Rawhide.

Before

After

@tintou I'm not sure if we need to fix the problem or if it's a bug in the bindings for Vala. What do you think?

tintou commented 1 year ago

Two suggestions but it looks good, this is due to a renamespace that I did in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4d325bafe193dc1fc4fbd0beabae7bb6ab8901bc

meisenzahl commented 1 year ago

@tintou thanks for your suggestions. I validated that it still compiles: https://github.com/meisenzahl/distro-agnostic/actions/runs/4782964418/jobs/8511499466

tintou commented 1 year ago

I'm unsure because odd number mean unstable release so at the end it would be HAS_NM_1_44 if we want to be correct :shrug:

meisenzahl commented 1 year ago

That would seem weird to me based on the version number. Then let's stick with HAS_NM_1_43. Unless you prefer HAS_NM_1_44.

vcunat commented 1 year ago

NM 1.44 was released two months ago. It would be nice to have a tag supporting that version.