elementary / switchboard-plug-onlineaccounts

Switchboard Online Accounts Plug
GNU General Public License v3.0
23 stars 16 forks source link

Fix use imap username for smtp #253

Closed stan-janssen closed 1 year ago

stan-janssen commented 1 year ago

This PR fixes a bug in the flow for setting up a new IMAP account.

Situation

The situation is as follows:

Solution

I added two commits to fix this.

  1. The first and primary one makes sure that we pass the IMAP username to the SMTP transport auth extension if the 'Use IMAP Credentials' option is active. This solves the original problem.
  2. The second commit makes sure that as long as the Use IMAP Credentials option is active, and the user changes whatever is input into the IMAP username field, the (now hidden) SMTP username field is updated as well. When the user does decide to deactivate the Use IMAP Credentials option, the starting point is now the current IMAP username.

These fixes were tested on ElementaryOS 7 with the latest updates, and seem to work fine.

stan-janssen commented 1 year ago

This fixes #239.