search

elementary / switchboard-plug-onlineaccounts

Switchboard Online Accounts Plug
GNU General Public License v3.0
23 stars 16 forks source link

ImapDialog: use Adw.NavigationView #283

Closed danirabbit closed 2 months ago

danirabbit commented 2 months ago

Replaces deprecated Leaflet

leolost2605 commented 2 months ago

I've left some comments about possible mem leaks. Because this is not a continually running process mem leaks aren't that bad here but I think we should kinda get aware of them because e.g. in dock we probably have quite a bunch since it starts with 200mb and after an hour or two of normal use it has 800mb :(

danirabbit commented 2 months ago

@leolost2605 How's that? :)

danirabbit commented 2 months ago

@leolost2605 okay how's this? I don't see any signal_connect_full in the generated C

leolost2605 commented 2 months ago

Sorry I typed it on my phone without checking, it should have been g_signal_connect_data 😖

danirabbit commented 2 months ago

@leolost2605 it looks like there was only one of those so I went ahead of fixed it even though it's not related to this branch :)