Color Scheme Chooser - Githubissues

elementary / switchboard-plug-pantheon-shell

Switchboard Desktop Plug

GNU General Public License v3.0

34 stars 24 forks source link

Color Scheme Chooser #215

Closed danirabbit closed 4 years ago

danirabbit commented 4 years ago

We need to come up with an interface for the prefers-color-scheme setting.

We should bear in mind that this setting has 3 states: prefer dark, prefer light, and no-preference (maybe we can call this mixed or automatic or something more palatable). It seems like most major platforms only handle no-preference and dark.

I think we want to do a slow rollout and start with only shell elements, so the first version of this should probably be two illustrations depicting light shell elements and dark shell elements. By shell elements I mean the dock and panel popovers.

It might be worth depicting mixed windows so that the user knows this only changes shell elements and not apps.

Future versions of this selector should probably be three illustatrations:

One with light shell elements and app windows
One with light shell elements and mixed app windows
One with dark shell elements and dark app windows

cassidyjames commented 4 years ago

We also don’t have to expose a light preference if we don't want to. :slightly_smiling_face: But I don't feel strongly, I guess it would probably be what some people immediately ask for.

danirabbit commented 4 years ago

Prior art from:

macOS

macos-dark-mode

iOS

darkmodeschedules

Ubuntu

dark-theme-settings-ubuntu-thumbnail-sized

cassidyjames commented 4 years ago

@danrabbit do we want to include agent dialogs as shell components? I feel like yes, but that could also come later.

I like the idea of showing mixed apps. Super rough whiteboard sketch:

IMG_20200420_114928

danirabbit commented 4 years ago

@cassidyjames Yeah I'm not sure at this size that it would be clear the difference between an agent and an app window

cassidyjames commented 4 years ago

Oops, top window was supposed to be dark (fixed w/updated sketch). Yeah, don't need to distinguish agents at this size.

danirabbit commented 4 years ago

Regarding the setting name, I think even if we only expose two settings we should avoid "Light" since that's not really true. And thinking about it, "automatic" could be confused for time-based. So maybe "Mixed" and "Dark"?

cassidyjames commented 4 years ago

Yeah defintely want to avoid "light" for a binary choice. That's why in the switch-bassed prototype #171 I just had it something like "prefer dark style" with descriptive text below. I don't know what that means for an illustration, though.

screenshot

"Mixed" feels weird to me, too. Maybe just "Default"? But I feel like no matter what we do, we're gonna want some descriptive text.

cassidyjames commented 4 years ago

Terrible, bad UI from Android/Pixel incoming. I think this is because they kind of bolted this feature on mid-cycle. But just for prior art completeness sake (and maybe an exercise in what not to do…)