search

elementary / switchboard-plug-parental-controls

Switchboard Screen Time & Limits Plug
https://elementary.io
GNU General Public License v3.0
11 stars 14 forks source link

Duplicates limit description for each period (Weekdays and Weekends) #133

Closed igordsm closed 3 years ago

igordsm commented 4 years ago

Closes #127 : Duplicates the limit message for each period and adds a new message indicating that logins during a period are not being limited.

Before

Screenshot from 2020-07-05 18-36-19

After

Screenshot from 2020-07-05 18-36-50

igordsm commented 4 years ago

Hey @cassidyjames , I tried to make this as close as possible to your ASCII mock. What do you think?

cassidyjames commented 3 years ago

@jeremypw I'm happy with the actual copy, but I agree the construction of translatable strings felt weird. "at the weekend" sounds really wrong for me in American English, at least; we'd usually say "on the weekend" or in this case more likely "on weekends" since it's a recurring thing.

jeremypw commented 3 years ago

@cassidyjames . OK, "on the weekend" sounds weird to me in the UK, but I guess a translation can be added in en_gb! "On weekends" sounds less weird for some reason although we would usually say "at weekends".

danirabbit commented 3 years ago

@cassidyjames @jeremypw so is there a conclusion about if this is okay for translators or if it needs to be changed?

jeremypw commented 3 years ago

@danrabbit The base text can be whatever sounds right in American, of couse, but I suggest you seek the opinion of @ryonakano for the best way to construct the strings for translatability. I would say at least the translatable string should be "on weekends" and "on weekdays" rather than just "weekends" and "weekdays".

ryonakano commented 3 years ago

I agree with the opinion of @jeremypw that it'd be more safe to have separate complete sentences for the weekend and weekdays. Although we provide a context for the title case text and sentence case text, some languages like CJK have no concept of "case" so these context notes may not be useful (or even confusing) for translators in there languages. The current code is well-DRYed though.

jeremypw commented 3 years ago

@igordsm Are you still available to address the issues raised by ryonakano?

igordsm commented 3 years ago

@jeremypw I somehow lost track of this. Will look into it the next few days.

igordsm commented 3 years ago

Given the points raised by @ryonakano , the translatable strings are now separated. I'm not sure the solution used it OK (a bool is_weekend was added), but at least the translatable strings make sense by themselves. Does this help with translatabilty?