elementary / switchboard-plug-parental-controls

Switchboard Screen Time & Limits Plug
https://elementary.io
GNU General Public License v3.0
11 stars 14 forks source link

Port Applications chooser from other plugs #37

Closed danirabbit closed 5 years ago

danirabbit commented 6 years ago

The way this application chooser is done, it will be affected by the issue mentioned here: https://elementaryos.stackexchange.com/questions/14929/add-startup-app-menu-broken

We should make this chooser match the one from Applications and Security & Privacy

peteruithoven commented 6 years ago

It's actually not, since it's scrollbar has a better policy, it's actually what I used in the end to fix the AppChooser in the Applications and Security plugs. (See: https://github.com/elementary/switchboard-plug-applications/pull/15)

screenshot from 2018-02-28 13-11-29

But it is quite a shame there we have similar code in 3 different plugs. Isn't there a way to share this code? I can imagine it would be a bit to specific to add to Granite for example?

One issue is that it looks different, for comparison: AppChooser in Applications plug

danirabbit commented 5 years ago

I'm gonna close this since the approw has been abstracted here and the design matches other plugs