search

elementary / switchboard-plug-power

Switchboard Power Plug
GNU General Public License v2.0
19 stars 13 forks source link

Add show percent in panel #167

Closed danirabbit closed 3 years ago

danirabbit commented 3 years ago

Problem

Choosing to show the battery percentage in the panel isn't something you frequently reference or change, so it probably doesn't need to be in the indicator. But there's currently nowhere else to change this setting

Proposal

Put the setting here so we can remove it from the indicator

cassidyjames commented 3 years ago

I'm unsure if we should remove it from the indicator, but it makes sense to have this here, too, regardless. :+1:

hanaral commented 3 years ago

I do think that it has a place in the indicator, but I'm wondering what you guys would think about a show-percent-when-below-X%-power system. It could even possibly just be like iOS, where it always shows the percentage when the device is in low power mode/has its battery level fall below X% and has a toggle for it to be permenant.

cassidyjames commented 3 years ago

@hanaral see: https://github.com/elementary/wingpanel-indicator-power/issues/149

andirsun commented 3 years ago

As I implement this PR https://github.com/elementary/wingpanel-indicator-power/pull/194 then I will migrate switch to power settings

andirsun commented 3 years ago

@cassidyjames @danrabbit Done ! First merge https://github.com/elementary/switchboard-plug-power/pull/193 Then merge https://github.com/elementary/wingpanel-indicator-power/pull/195