elementary / switchboard-plug-power

Switchboard Power Plug
GNU General Public License v2.0
19 stars 13 forks source link

Port to Gtk4 #217

Closed treppenwitz03 closed 1 year ago

treppenwitz03 commented 2 years ago

Goes with https://github.com/elementary/switchboard/pull/231

Blocked by:

Todo:

lenemter commented 2 years ago

I had to change the way authentication works. Here permission is asked on opening combobox. Trying to replicate the way auth in master works gives this: image

jeremypw commented 2 years ago

There are some visual glitches at the moment when using gtk4 which may not be to do with code you have written. Either from upstream or maybe Gala. It would be better to maintain the behaviour approved for Gtk3 if at all possible. I'll have a look into it.

jeremypw commented 2 years ago

CI failing because of upstream issue. See https://github.com/elementary/docker/issues/25

lenemter commented 2 years ago

@jeremypw Yes, it does. But I found a big issue in both gtk3 and gtk4 versions. While authentication dialog is open, focus settings window using alt+tab or click and wait, after a short time "Not responding" window starts pop up every 5 seconds, even after you close auth dialog and power plug itself

lenemter commented 2 years ago

I found the exact same issue in gtk3 locale plug

jeremypw commented 2 years ago

As the same problem occurs in more than one plug I am going to raise a separate issue.