search

elementary / switchboard-plug-sharing

Switchboard Sharing Plug
GNU General Public License v3.0
10 stars 10 forks source link

Disable content grid child switches when service switch is off #43

Closed tjchester closed 3 years ago

tjchester commented 4 years ago

Resolves #1 - Change all child switches to off when parent switch is off

ryonakano commented 4 years ago

I think this is intentional. By not changing the state of child switches when the service switch turns off, users can restore their customized sharing setting just by turning on the service switch again.

tjchester commented 4 years ago

I updated the PR description to include the issue link. If as @ryonakano suggested that we wanted to preserve the user's sharing settings, as an alternative we could just hide the content-grid when the service is disabled.

ryonakano commented 4 years ago

@tjchester Thank you for quoting the issue link! We seem to need some discussion about the design.

jeremypw commented 3 years ago

@tjchester Closing as has unaddressed issues and no recent activity. Please feel free to reopen (as draft) if you wish to continue working on it.