search

elementary / switchboard-plug-sharing

Switchboard Sharing Plug
GNU General Public License v3.0
10 stars 10 forks source link

GnomeRemoteDesktopSupport WIP #60

Open BAProductions opened 1 year ago

BAProductions commented 1 year ago

Fixes #56

Problem Since installing eOS 6-6.1 on my HTPC and early this years upgrading my HTPC with newer Parts and installing eOS 7-7.1 on my old HTPC in a VM that's ruining on a 500GB SATA SSD via Project-Cockpit Running on Ubuntu Server 24.04 on a 2 Core intel i3 i decided to revisit the hole vnc thing and after doing some research I came Gnome vino-server Gnome Remote Desktop & Gnome Remote Connection witch lead me issue #56 here a user made a post about adding Gnome Remote Desktop to eOS an after installing Gnome Control Center on eOS 7-7.1 & madding with gsetting and dconf editor it works beautifully with barely any lags at all

Proposal My proposal Is to add Gnome Remote Desktop and Gnome Remote Connection support to elementary/switchboard-plug-sharing and all feedback is appreciated.

Prior Art (Optional)

Screenshot 2023-02-04 at 11 12 15 AM
jeremypw commented 1 year ago

There are a number of elementaryos code style issues. You should install vala-lint (available at https://github.com/vala-lang/vala-lint) to check for these locally.

jeremypw commented 1 year ago

Thanks for making a start on this though! I'll try to look at it in more detail soon.

jeremypw commented 1 year ago

I have inserted "Fixes #56" into the description so that if this PR is merged into master then that issue is automatically closed (I assume that this PR is intended to completely resolve that issue).

I am not sure if this PR is complete and working? If it is not then please convert to "draft" - it will still be visible and attract comment.

BAProductions commented 1 year ago

I have inserted "Fixes #56" into the description so that if this PR is merged into master then that issue is automatically closed (I assume that this PR is intended to completely resolve that issue).

I am not sure if this PR is complete and working? If it is not then please convert to "draft" - it will still be visible and attract comment.

How

jeremypw commented 1 year ago

@BAProductions For my own PRs I see an option to convert to draft just under the "Reviewers" section on the right hand side: image

Oh - I see you have done it!

jeremypw commented 1 year ago

Note: Spelling of "Legicy" should be "Legacy".