elementary / switchboard

Extensible System Settings app designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
49 stars 15 forks source link

Application: don't handle plug nav #246

Closed danirabbit closed 8 months ago

danirabbit commented 2 years ago

This moves the headerbar into the leaflet such that there is no headerbar supplied for plugs and they will have to provide their own window controls and navigation button. The reasoning behind this is that as we're moving to responsiveness we may have plugs that will use multi-column layouts and it would be awkward to have two layers of navigation on screen at once when columns are collapsed on top of each other such as in a leaflet.

Screenshot from 2022-09-10 11 54 15

jeremypw commented 1 year ago

Works for me with elementary/switchboard-plug-mouse-touchpad#206 But every time any plug being closed is prints some errors:

(io.elementary.settings:22633): switchboard-CRITICAL **: 23:54:30.399: switchboard_plug_shown: assertion 'self != NULL' failed

(io.elementary.settings:22633): switchboard-CRITICAL **: 23:54:30.399: switchboard_plug_get_display_name: assertion 'self != NULL' failed

I fixed these errors in main in #260. You might want to incorporate the fix here as it is simple.