Closed danirabbit closed 7 months ago
@danirabbit I cannot compile https://github.com/elementary/switchboard-plug-bluetooth/pull/216 even with this branch installed - what else do I need to do? Error is:
../src/MainView.vala:22.35-22.64: error: The type name `Switchboard.SimpleSettingsPage' could not be found
22 | public class Bluetooth.MainView : Switchboard.SimpleSettingsPage {
I think it was renamed to SettingsPage
instead of SimpleSettingsPage
here
Yup, just updated it! I ended up breaking API here a little harder than I though :sweat_smile:
Can test with https://github.com/elementary/switchboard-plug-bluetooth/pull/216
Makes SettingsPage a Gtk.Widget instead of Gtk.Box so we're not exposing extra unwanted API and make it so settings a
child
sets the content area child not overwrites the whole page. Also get rid of the separate simple page and abstract page, everything is only using the simple page. While we're here, clamp things!