CategoryView: cleanup - Githubissues

elementary / switchboard

Extensible System Settings app designed for elementary OS

https://elementary.io

GNU Lesser General Public License v2.1

48 stars 15 forks source link

CategoryView: cleanup #287

Closed danirabbit closed 7 months ago

danirabbit commented 7 months ago

Review with "hide whitespace"

Screenshot from 2024-01-31 09 55 37

Bump copyright header
Inline namespace
Set padding/margin with CSS
Float searchbar
Fix scrollbar location
Reduce number of clamps, scrolled boxes, and stacks
Make objects way more private
Fix issues with search and keyboard nav
Code style
Remove an idle that caused plugs to load in late and make the view jump on launch every time

danirabbit commented 7 months ago

Yeah I noticed it looks like maybe a change in behavior in GTK? the flowboxes don't seem to be able to keyboard nav between them either

jeremypw commented 7 months ago

Might be able to fix by putting the EventControllerKey in the CAPTURE phase and catching the Up key before it is swallowed by the FlowBox but its not a big deal.