search

elementary / switchboard

Extensible System Settings app designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
48 stars 15 forks source link

SettingsPage: add with_avatar option #291

Closed danirabbit closed 7 months ago

danirabbit commented 7 months ago

The only custom header widget we ever use is an Avatar, so add an option for that instead of the display_widget option which doesn't really work and isn't used

Can test with https://github.com/elementary/switchboard-plug-parental-controls/pull/187

Screenshot from 2024-02-01 14 26 34

Theoretically SettingsSidebarRow is also set up in this branch, but it'll take more work to make a branch to test that with so I'm assuming I'll need to follow up there to make it work properly

jeremypw commented 7 months ago

@danirabbit Needs conflict resolved.

danirabbit commented 7 months ago

@jeremypw yeah I wondered if it might need to be casted as well, but seems to work!