elementary / terminal

Terminal emulator designed for elementary OS
https://elementary.io
GNU Lesser General Public License v3.0
403 stars 97 forks source link

Closing Terminal does not warn about open background tasks #20

Open elementaryBot opened 7 years ago

elementaryBot commented 7 years ago

It's easy to suspend Ctrl+Z a task, and forget about it, In such scenarios closing the terminal should result in a warning, confirming if the user really wants to close and kill the background tasks.

Launchpad Details: #LP1050321 Darcy Luís Neves Brás da Silva - 2012-09-13 09:53:24 +0000

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/44562201-closing-terminal-does-not-warn-about-open-background-tasks?utm_campaign=plugin&utm_content=tracker%2F61246377&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F61246377&utm_medium=issues&utm_source=github).
elementaryBot commented 7 years ago

You are right, that is wishlist :)

On Thu, Sep 13, 2012 at 1:18 PM, Darcy Brás da Silva <

elementaryBot commented 7 years ago

We use Launchpad ones:http://i.imgur.com/I15LH.png

On Mon, Sep 17, 2012 at 8:14 PM, Darcy Brás da Silva <

elementaryBot commented 7 years ago

Additionally, I add the following criteria when I mark importance:

Critical: This is probably a crasher. This problem makes the app completely unusable and is an emergency.

Low: This is an annoyance, but it does not prevent a user from using the app. Likely a "papercut" or small visual design issue.

Wishlist: This is not a problem with existing features, this is an enhancement or a new feature.

On Mon, Sep 17, 2012 at 12:16 PM, David Gomes

On Mon, Sep 17, 2012 at 8:14 PM, Darcy Brás da Silva

On Mon, 2012-09-17 at 19:55 +0100, David Gomes wrote:

You are right, that is wishlist :)

On Thu, Sep 13, 2012 at 1:18 PM, Darcy Brás da Silva

-- Darcy Brás da Silva

Launchpad Details: #LPC Daniel Fore - 2012-09-17 19:23:05 +0000

elementaryBot commented 7 years ago

Dan: +1 that's pretty much exactly what I use too.

On Mon, Sep 17, 2012 at 2:23 PM, Darcy Brás da Silva <

elementaryBot commented 7 years ago

Also where we are in the milestone (nearing release) factors in too, right now certain things are more likely to have a lower priority than if we were working on Luna+1.

On Mon, Sep 17, 2012 at 2:49 PM, Cody Garver

Dan: +1 that's pretty much exactly what I use too.

On Mon, Sep 17, 2012 at 2:23 PM, Darcy Brás da Silva <

-- Cody Garver

Launchpad Details: #LPC Cody Garver - 2012-09-17 19:50:28 +0000

elementaryBot commented 7 years ago

Still a valid issue. We should either issue the warning or just bring that stopped task back up when you reopen Terminal (personally I'm a fan of the latter)

Launchpad Details: #LPC Daniel Fore - 2015-05-02 00:09:36 +0000

waldyrious commented 7 years ago

We should either issue the warning or just bring that stopped task back up when you reopen Terminal (personally I'm a fan of the latter)

In case such jobs have already been restarted in the background (e.g. using bg), another option could be to silently disown the job before closing Terminal, so that the job isn't killed. But a warning could still be warranted, since the output from that job would then be lost (AFAIK).