elementary / terminal

Terminal emulator designed for elementary OS
https://elementary.io
GNU Lesser General Public License v3.0
399 stars 96 forks source link

Application: Implement `startup()` #710

Closed Marukesu closed 1 year ago

Marukesu commented 1 year ago

Handy initialization and CSS loading is done here now, the new-window and quit action are implemented here too since there's no reason for them to be part of the window class. one behaviour diference is that the quit action now closes all windows instead of only the current window matching others elementary applications.

jeremypw commented 1 year ago

@Marukesu #709 is merged - a conflict needs to be resolved.

Marukesu commented 1 year ago

@jeremypw testing locally, the CI was falling because of the Idle in on_switch_page() in the MainWindow class. #720 should fix it.

jeremypw commented 1 year ago

For me it was failing in the "quit" action test. I tried to fix it but failed. We could always leave that test out and fix it later if necesssary.

jeremypw commented 1 year ago

720 now merged ... but CI still failing :disappointed: However, CI passed locally :man_shrugging:

jeremypw commented 1 year ago

Hmm, contrary to my previous diagnosis the CI is (now) failing on the "new-window" action test. See #723

Marukesu commented 1 year ago

Hmm, contrary to my previous diagnosis the CI is (now) failing on the "new-window" action test. See #723

the new-window test is fine, GLib.Test.skip() don't return by itself, so the assertion in the quit test got triggered.