Fix unwanted extra tab - Githubissues

elementary / terminal

Terminal emulator designed for elementary OS

https://elementary.io

GNU Lesser General Public License v3.0

399 stars 96 forks source link

Fix unwanted extra tab #743

Closed jeremypw closed 5 months ago

jeremypw commented 8 months ago

Fixes #736

Application only adds an extra tab only when specifically asked
MainWindow adds an extra tab when required to ensure at least one tab

jeremypw commented 6 months ago

Fixing CI ...

jeremypw commented 5 months ago

@Marukesu Thanks for the detailed review. I have tried to address your comments. I have reduced the scope of this PR to not include path abbreviations. This will be addressed in a separate PR.

If the behaviour is now as expected, please feel free to push a commit rearranging the code as you would like.

jeremypw commented 5 months ago

I have now pushed a possible fix for the relative path issue. After this commit both io.elementary.terminal -w ../src and io.elementary.terminal --working-directory=../src behave as expected.