search

elementary / terminal

Terminal emulator designed for elementary OS
https://elementary.io
GNU Lesser General Public License v3.0
399 stars 96 forks source link

TerminalWidget: Port Context Menu to GLib.MenuModel and Gtk.PopoverMenu #751

Open Marukesu opened 7 months ago

Marukesu commented 7 months ago

In preparation to Gtk4. The changing from Gtk.Menu to Gtk.PopoverMenu happens because Gtk.Menu will inherit the monospace font from the TerminalWidget, sadly, it requires that we lost the accels in the menu for now.

jeremypw commented 7 months ago

How near are we to switching to Gtk4? Would it be better to leave this until switch is imminent so degradation of UI is minimised?

Marukesu commented 7 months ago

How near are we to switching to Gtk4?

We don't have the Gtk4 version of VTE in jammy, so it would need to wait for once we are "done" with releases for OS 7.

Would it be better to leave this until switch is imminent so degradation of UI is minimised?

I'm fine in waiting for it, this part of code won't have much changes, if any, until there.

jeremypw commented 7 months ago

Adding blocked label - waiting for Gtk4 version of Vte.