search

elementary / terminal

Terminal emulator designed for elementary OS
https://elementary.io
GNU Lesser General Public License v3.0
406 stars 97 forks source link

Fix inoperative header decorations when fullscreened #753

Closed jeremypw closed 8 months ago

jeremypw commented 10 months ago

Fixes #752

When fullscreened, the default decoration is overridden to show only the Close button (which still works) and a custom "Exit Fullscreen" button is revealed to replace the inoperative "Maximize/UnMaximise" button (with the same icon but with a Granite tooltip). This follows the method used by Epiphany (except that Epiphany does not use a tooltip).

If this solution is accepted then it could also be used for e.g. Code which has the same issue.

jeremypw commented 8 months ago

@Marukesu Thanks for the suggestion - can it be left for another PR? The current version of epiphay in 7.1 only has a "maximise" button in the headerbar. It does have a "fullscreen"button in the AppMenu though.

Marukesu commented 8 months ago

@jeremypw you already implemented my suggestion. a fullscreen button in the menu would be good indeed, but that can be left to another PR.