search

elementary / videos

Video player and library app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
58 stars 18 forks source link

Combine Subtitles and External Subtitles chooser #125

Open cassidyjames opened 5 years ago

cassidyjames commented 5 years ago

Moved from https://bugs.launchpad.net/audience/+bug/1362910

@codygarver:

Right now there's a dropdown for internal subtitle tracks and a filechooser button for external subtitle files

Instead they should all be one dropdown like this:

Subtitles: English
           None
           Other...

@vikoadi:

just some of my idea https://blueprints.launchpad.net/audience/+spec/divide-cogs-popover see attached mockup, maybe should add file chooser entry on my mockup.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/70573496-combine-subtitles-and-external-subtitles-chooser?utm_campaign=plugin&utm_content=tracker%2F61134914&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F61134914&utm_medium=issues&utm_source=github).
peteruithoven commented 5 years ago

Please note that there is no proper support for external subtitles currently. So my suggestion has been to remove the external subtitles UI for now: https://github.com/elementary/videos/issues/63