Port to GTK4 - Githubissues

elementary / videos

Video player and library app designed for elementary OS

https://elementary.io

GNU General Public License v3.0

58 stars 18 forks source link

Port to GTK4 #289

Closed treppenwitz03 closed 2 years ago

treppenwitz03 commented 2 years ago

Depends on Granite Where we are blocked:

[ ] Replace Gtk.TargetEntry as this no longer exists in GTK4
[ ] Replace Gtk.DragContext and Gtk.SelectionData for same reasons.
[ ] Replace Gtk.FileChooserButton as it is also dropped
[ ] Replace Gtk.Menu Instances
[ ] Replace Event handling as EventButton is dropped
[ ] Lastly, GtkClutter is still in GTK3 which hinders porting

Marukesu commented 2 years ago

Lastly, GtkClutter is still in GTK3 which hinders porting

that need to be replaced with Gtk.Video, you will need to port the Audience.Widgets.BottomBar to be an Gtk.MediaControls too. (thinking about elementary/granite#268, we problably wants to do this there too?)

treppenwitz03 commented 2 years ago

Lastly, GtkClutter is still in GTK3 which hinders porting

that need to be replaced with Gtk.Video, you will need to port the Audience.Widgets.BottomBar to be an Gtk.MediaControls too. (thinking about elementary/granite#268, we problably wants to do this there too?)

I agree so we can have uniform media controls across different apps. But I read that there will be discussion on what will be changed on granite. Maybe we can raise this then