search

elementary / videos

Video player and library app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
59 stars 18 forks source link

Gtk4 #333

Closed leolost2605 closed 10 months ago

leolost2605 commented 1 year ago

Todo:

Pretty much ready however there is the issue that dragging and dropping in the PlaylistPopover causes some really weird issues (e.g. the popover can't be closed and will stay on top even if other applications get focused, also the main window can't be focused and doesn't respond to input). I'm not 100% sure but I think this might be an issue in mutter/gala/gtk so I don't think we can do anything about it currently (this issue also exists in the gtk4 widget factory; also there seem to be problems with DND in popovers on wayland (see this issue)). Maybe worth noting is that when autohide=false this doesn't occur however IMO that's not a perfect solution. Maybe we can use a separate window instead of a popover or disable DND in the playlist entirely for now?

Also this uses this gst plugin written in rust. It's currently by far the easiest way to get GTK4 integration with gstreamer. It needs the rust SDK though which is why CI is failing, any tips here?

danirabbit commented 11 months ago

I think @davidmhewitt has experience with rust stuff because of Torrential

leolost2605 commented 11 months ago

Hmm I just need a way to install the rust SDK in CI because it isn't in appcenter. Maybe we can add flathub as an additional source?

davidmhewitt commented 11 months ago

Yeah, you can just add this to the GitHub action:

      - name: Install Rust SDK extension
        run: |
          flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
          flatpak install -y --arch=${{matrix.arch}} org.freedesktop.Sdk.Extension.rust-stable//22.08

It's only needed for the build, so users don't need it installed to run.

danirabbit commented 11 months ago

@leolost2605 Yeah let's just pull out the Drag n Drop stuff for now since it's broken. I'd really like to make some larger design changes in this app anyways in future branches :)

danirabbit commented 10 months ago

@leolost2605 fixed that menu align. If you think this is ready, I think let's get it merged since we just did a release and there's plenty of time to fix up any rough corners we find while testing :)

leolost2605 commented 10 months ago

@danirabbit sure as far as I'm concerned this is ready. Also you said something about some design changes, if you've got some mockups I could work on implementing them :) Since music library is unfortunately forced on hold until OS8...