elementary / videos

Video player and library app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
58 stars 17 forks source link

Headerbar improvements #368

Closed leolost2605 closed 1 year ago

leolost2605 commented 1 year ago
zeebok commented 1 year ago

You have a conflict with master to resolve! :)

zeebok commented 1 year ago

So if my testing shows anything, this alters what happens in fullscreen so that it shows the header and hides it away instead of the unique maximize button it used to have, correct? It certainly works better! I noticed the maximize button state can get confused in the current version.

leolost2605 commented 1 year ago

So if my testing shows anything, this alters what happens in fullscreen so that it shows the header and hides it away instead of the unique maximize button it used to have, correct?

I think what you mean was already implemented in #361 :)

I noticed the maximize button state can get confused in the current version.

With current version you mean main? If not then there is something wrong here

zeebok commented 1 year ago

With current version you mean main? If not then there is something wrong here

Sorry, yes, I mean the current release on AppCenter. Your version seems good!