elementary / wallpapers

Collection of wallpapers for elementary OS
https://elementary.io
Other
508 stars 61 forks source link

Dynamic Wallpapers with .xml files added to /backgrounds #146

Closed saint-13 closed 3 years ago

saint-13 commented 3 years ago

Screenshot(s) of it in Pantheon on elementary OS:

cassidyjames commented 3 years ago

@saint-13 thanks for submitting this! At this time we don't have plans for multiple time-based edits of wallpapers. Even so, in the future, please submit a smaller pull request with just one change (e.g. one wallpaper) instead of a massive one with tons of changes, as it's much harder to review and keep in sync.

The GNOME XML format is also undocumented and not supported by Gala at this time.

We do have plans to address light/dark variants of wallpapers, but we want to ensure it is synced with the user's preference rather than just time of day.

saint-13 commented 3 years ago

@cassidyjames thanks for reviewing my pull request. I really like ElementaryOS, and I just want somehow contribute to project. Sorry, it was my first pull request. and I was a little bit excited! I wish in future I can help with more technical stuff, not just wallpapers. Do you think those picture are any good? if so, i will create 2 new pull requests for "Snow-Capped Mountain Day.jpg" and "Sunset by the Pier Night.jpg".

cassidyjames commented 3 years ago

@saint-13 no worries! I personally think they feel a bit over-processed, but wouldn't be opposed to considering alternate versions of those wallpapers (especially if we do find a good way to get automatic dark style wallpapers working). You can create a PR for those individually and they can be discussed there.