Add Meson build system - Githubissues

elementary / wallpapers

Collection of wallpapers for elementary OS

https://elementary.io

Other

508 stars 61 forks source link

Add Meson build system #47

Closed danirabbit closed 6 years ago

danirabbit commented 6 years ago

[x] Install and test with Meson
[x] Update packaging to install with Meson
[x] Update Travis to test with Meson

codygarver commented 6 years ago

Also I think this:

project('io.elementary.wallpapers', 'c')

Should be this:

project(
    'io.elementary.wallpapers',
    version: '1.2.3.4.5'
)

codygarver commented 6 years ago

Also your test instructions could be

meson build && ninja -C build test

danirabbit commented 6 years ago

@codygarver I cannot without writing a custom script. Meson doesn't support wildcards https://github.com/mesonbuild/meson/blob/master/docs/markdown/FAQ.md

"Meson does not support this syntax and the reason for this is simple. This can not be made both reliable and fast."

If we moved all the wallpapers into a directory, I could just install the whole directory, but the array would still be needed to tests because you can't use wildcards in commands run by meson either.

codygarver commented 6 years ago

I'm abstaining from this review because I feel like giving this repo a build system that can't glob *.jpg is gilding the lily.

Because it's creating friction and pitfalls for what was a simple process: stick a jpg in and open a PR. With no gain IMO.

danirabbit commented 6 years ago

Yeah that's a fair perspective. To me, my motivations were/are:

Have a consistent way to run tests for all repos. This makes it so you can test this repo with the same command we use on all repos
Shift installation responsibility away from packaging. I think we're probably a better upstream when we do less in our Debian packaging
Set a foundation for being able to pass a build flag for including/excluding the beta wallpaper in the installation. This would put all of our wallpapers in one repo and make sure that it's subject to the same wallpaper tests.