search

elementary / wallpapers

Collection of wallpapers for elementary OS
https://elementary.io
Other
508 stars 61 forks source link

Add 'Lamp post on dock'. #99

Closed ghost closed 4 years ago

ghost commented 4 years ago

Screenshot(s) of it in Pantheon on elementary OS:

I couldn't do this I'm afraid as I'm not (yet) an Elementary OS user. I tried GIMPing it onto the examples in the README, but it looked yuk when I tried to remove the background from them...

ghost commented 4 years ago

I couldn't find a debian/copyright file, so couldn't do that bit I'm sorry. The image is from here though: https://unsplash.com/photos/0HFkStS9Gq0

ghost commented 4 years ago

Lamp post on dock

cassidyjames commented 4 years ago

Thanks for the PR!

Ah, yeah we need to update the instructions for copyright info (or auto-build that file in CI or something). It's in a different branch, but that requires another PR to update.

Here's a screenshot on elementary OS:

Screenshot from 2020-04-14 14-15-10@2x

Personally, I'm :-1: on this one… I like the photo itself alright, but it feels like being non-centered is super obvious with the dock there.

ghost commented 4 years ago

@cassidyjames Hmm, good point... Would it be worth cropping the image somewhat then? Something like this:

cropped-dock (I GIMPed the dark README example, that seemed easier than the light one)

If so, I'll update the PR.

As for the copyright file, I've created an issue for that here: https://github.com/elementary/wallpapers/issues/100

danirabbit commented 4 years ago

Hm yeah it's a bit similar to Sunset by the pier as well. I think if we were to include this one, it would have to replace the other one

ghost commented 4 years ago

Based on the comments above (which make valid points), I'm going to close this PR (not centred and too similar to existing image).